Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing CODEOWNERS and MAINTAINERS file #635

Merged
merged 1 commit into from
May 4, 2024

Conversation

MDr164
Copy link
Contributor

@MDr164 MDr164 commented May 3, 2024

No description provided.

@MDr164 MDr164 requested a review from a team May 3, 2024 14:40
@MDr164 MDr164 force-pushed the maintainers-file branch from dae956b to 2927b92 Compare May 3, 2024 14:41
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.90%. Comparing base (14cf073) to head (cd232ef).
Report is 20 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #635      +/-   ##
==========================================
+ Coverage   70.51%   72.90%   +2.38%     
==========================================
  Files          10       10              
  Lines        2123     1657     -466     
==========================================
- Hits         1497     1208     -289     
+ Misses        505      328     -177     
  Partials      121      121              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MDr164 MDr164 force-pushed the maintainers-file branch from 2927b92 to cd232ef Compare May 4, 2024 21:02
@MDr164 MDr164 merged commit 5a634eb into theupdateframework:master May 4, 2024
23 checks passed
@MDr164 MDr164 deleted the maintainers-file branch May 4, 2024 21:05
- rdimitrov
- kommendorkapten
- mnm678
- znewman01
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @znewman01 left as a maintainer?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Zack should say something if that is not the case, but he is still also in the @theupdateframework/go-tuf-maintainers list.

Copy link
Contributor Author

@MDr164 MDr164 May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I just copied who was in the maintainers list in the org. If that info was outdated we should both change it there and in this file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that makes sense, we should use that list as authoritative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants