Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MAINTAINERS #636

Merged
merged 3 commits into from
May 21, 2024
Merged

Update MAINTAINERS #636

merged 3 commits into from
May 21, 2024

Conversation

trishankatdatadog
Copy link
Member

No description provided.

@trishankatdatadog
Update MAINTAINERS
011d6fd 
Signed-off-by: Trishank Karthik Kuppusamy <[email protected]>
@trishankatdatadog trishankatdatadog requested a review from a team as a code owner May 21, 2024 15:12
MDr164
MDr164 previously approved these changes May 21, 2024
View reviewed changes
@MDr164
Copy link
Contributor

MDr164 commented May 21, 2024

Good to see the autoassign works, thanks Trishank for taking care of the update!

@trishankatdatadog
move to MD
5977367 
Signed-off-by: Trishank Karthik Kuppusamy <[email protected]>
@trishankatdatadog trishankatdatadog force-pushed the trishankatdatadog-patch-1 branch from 1102cca to 5977367 Compare May 21, 2024 15:20
@trishankatdatadog
Copy link
Member Author

@JustinCappos can you give @theupdateframework/go-tuf-maintainers admin access to the team itself?

MDr164
MDr164 previously approved these changes May 21, 2024
View reviewed changes
@trishankatdatadog
Update MAINTAINERS.md
09d0567 
Signed-off-by: Trishank Karthik Kuppusamy <[email protected]>
@trishankatdatadog
Copy link
Member Author

Good to see the autoassign works, thanks Trishank for taking care of the update!

Sorry, last change, I swear

@MDr164
Copy link
Contributor

MDr164 commented May 21, 2024

Good to see the autoassign works, thanks Trishank for taking care of the update!

Sorry, last change, I swear

Githubs CI also seems to be down so technically we should also wait for that to pass even though none of the checks except DCO are mandatory.

@trishankatdatadog
Copy link
Member Author

Githubs CI also seems to be down so technically we should also wait for that to pass even though none of the checks except DCO are mandatory.

There's also that too much bold heading in the Markdown, but I'll let someone else fix that now if they like...

@trishankatdatadog trishankatdatadog marked this pull request as draft May 21, 2024 15:29
MDr164
MDr164 approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@MDr164 MDr164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the markdown as is

@trishankatdatadog trishankatdatadog marked this pull request as ready for review May 21, 2024 16:57
@trishankatdatadog trishankatdatadog merged commit ef106d8 into master May 21, 2024
23 checks passed
@trishankatdatadog trishankatdatadog deleted the trishankatdatadog-patch-1 branch May 21, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDr164 MDr164 MDr164 approved these changes

@mnm678 mnm678 mnm678 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trishankatdatadog @MDr164 @mnm678