Metadata API: Remove Signed.bump_version() method #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1681854029Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
joshuagl
approved these changes
Jan 4, 2022
Remove `bump_version()` method, which is just an alias for "+= 1" on the version attribute. For a slim low-level API it seems okay to just directly access/modify the attribute. The extra level of abstraction of "bumping a version" is more appropriate for a repository library (see theupdateframework#1136). This patch also removes a related unit test and updates another one to directly do `(...).version +=`. Signed-off-by: Lukas Puehringer <[email protected]>
lukpueh
force-pushed
the
rm-metadata-api-bump_version
branch
from
a0972b6 to
8620f38
Compare
|
Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1736 (see #1736 (review))
Description of the changes being introduced by the pull request:
Remove
bump_version()method, which is just an alias for "+= 1" on the version attribute. For a slim low-level API it seems okay to just directly access/modify the attribute.The extra level of abstraction of "bumping a version" is more appropriate for a repository library (see #1136).
This patch also removes a related unit test and updates another one to directly do
(...).version += 1.Please verify and check that the pull request fulfills the following
requirements: