Fix two new pylint warnings #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New pylint warnings appeared related to changes in urlib3: - tests/test_fetcher_ng.py:128: error: Argument 1 to "ReadTimeoutError" has incompatible type "None"; expected "ConnectionPool" [arg-type] - tests/test_fetcher_ng.py:128: error: Argument 2 to "ReadTimeoutError" has incompatible type "None"; expected "str" [arg-type] I noticed these error in this CI run: https://github.com/theupdateframework/python-tuf/runs/4764931441?check_suite_focus=true I fixed them by creating a urllib3.HTTPConnectionPool() instance as the first argument and replaced the second argument with an empty string. This seems to do the job. Signed-off-by: Martin Vrachev <[email protected]>
This was referenced Jan 10, 2022
Pull Request Test Coverage Report for Build 1678751200Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
jku
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes being introduced by the pull request:
New pylint warnings appeared related to changes
in urlib3:
has incompatible type "None"; expected "ConnectionPool" [arg-type]
has incompatible type "None"; expected "str" [arg-type]
I noticed these errors in this CI run:
https://github.com/theupdateframework/python-tuf/runs/4764931441?check_suite_focus=true
I fixed them by creating a urllib3.HTTPConnectionPool() instance as
the first argument and replaced the second argument with an empty
string.
This seems to do the job.
Signed-off-by: Martin Vrachev [email protected]
Please verify and check that the pull request fulfills the following
requirements: