Update securesystemslib extras #2750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12557732266Details
💛 - Coveralls |
|
Adding on my TODO |
jku
force-pushed
the
update-securesystemslib-extras
branch
from
ce37c6e to
d8e65a6
Compare
|
rebased on develop |
jku
commented
Dec 17, 2024
Comment on lines
+21
to
+22
| securesystemslib==1.2.0 | ||
| # via -r requirements/main.txt |
There was a problem hiding this comment.
the extras are no longer documented in this file since pip-compile is changing the default output to be compatible with "--constraints" (meaning no extras): this seems sensible.
I'm explicitly using pip-compile --strip-extras as the command so we won't get bitten by one version of pip-compile having a different default than another version at some point in future
This is obsolete by now. Signed-off-by: Jussi Kukkonen <[email protected]>
The only real change is pynacl being removed. The command used to generate the list is documented in the generated file. Note that --strip-extras is used: it will be default soon anyway. Signed-off-by: Jussi Kukkonen <[email protected]>
jku
force-pushed
the
update-securesystemslib-extras
branch
from
d8e65a6 to
83ec7be
Compare
|
rebased on develop |
kairoaraujo
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pynacl is no lo longer either a dependency or "extras" name of securesystemslib 1.0 (which we already require)