Get clippy CI job working
#401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briansmith
force-pushed
the
b/clippy
branch
2 times, most recently
from
d4dc114 to
2463ded
Compare
briansmith
force-pushed
the
b/clippy
branch
4 times, most recently
from
6723d9e to
9ef4b42
Compare
`path` is already a reference, so don't double-borrow it.
The called function is generic over `Intoiterator` so don't call `into_iter()` on the parameter passed to it.
It seems like the `needless_borrows_for_generic_args` lint is being way to aggressive here, so just ignore it.
It's probably good advice but it should be dealt with in its own PR.
The latest version of tempfile (because of its dependency rustix, at least) requires 1.63.0. Similarly, the latest version of Tokio requires it. The latest Chrono also requires 1.57.0. Add a clippy.toml that prevents Clippy from recommending changes that require a newer toolchain. This is required or else the `clippy` job fails with advice to use APIs that are only in later versions.
erickt
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commits for details. Roughly:
chrono. This requires bumping the minimumchronoversion.