Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON contains empty scramble strings instead of an empty array for Mutli-Blind extras #895

Open
lgarron opened this issue Jan 8, 2024 · 3 comments

Comments

@lgarron
Copy link
Member

lgarron commented Jan 8, 2024

Actual (problem) behavior

Scrambles for 333mbf now contain:

"extraScrambles": ["", "", ""]

… where previously they used to contain:

"extraScrambles": []

There are no passcodes for these extras in the passcodes file.

Expected behavior

The scrambles are either provides with passcodes, or not at all.

Steps To Reproduce

  1. Work through Multi-Blind generation runs into No multiBLD number for round #894 until "Generate" works and inspect .json in the the resulting .zip.

Desktop (please complete the following information):

  • OS: macOS 14.2.1
  • Browser: Chrome 120
  • TNoodle Version 1.2.1
  • Java version [e.g. Java 8] (how to find out)

Additional context [OPTIONAL]

This tripped me up while updating https://github.com/cubing/scramble-table/ . Not only did the passcodes file format change a bit, but the JSON is now inconsistent with it.

lgarron added a commit to cubing/scramble-table that referenced this issue Jan 8, 2024
@lgarron
Copy link
Member Author

lgarron commented Jan 8, 2024

Note that I don't really need a fix for this, as I've already added a workaround for it.

@gregorbg
Copy link
Member

gregorbg commented Jan 8, 2024

Thanks, this is indeed not intended.

What do you mean by "Not only did the passcode file format change a bit"?

@lgarron
Copy link
Member Author

lgarron commented Jan 15, 2024

What do you mean by "Not only did the passcode file format change a bit"?

TNoodle 1.1.2 left off "Scramble Set A" from round descriptions of the passcode files if there was only one scramble set in the round:

cubing/scramble-table@760b275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants