Improve PDF font size detection #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll do a deep test in the weekend, please hold on. |
|
Could you please debug this?
http://localhost:2014/scramble?staging=true&competitionId=Jackson52021 |
gregorbg
force-pushed
the
fixup/general-pdf-rendering
branch
from
82e80cc to
221a1cd
Compare
|
I cannot reproduce the |
|
Well, it worked now, after failing a lot of times. It looked like ws connection was closing before generating all the scrambles. |
campos20
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a compromise between the "M-hack" and the over-simplified computation that Alexandre proposed.
It tries to fit the text on one line, and only if it becomes too small it distributes the scramble over multiple lines.
Prior to this PR, even events like 2x2 would sometimes stretch over multiple lines.
Bonus: The heading "Extra scrambles" is now bold.