Suppress type deprecation warnings for ArrayAccess on PHP 8.1

[enricobono]

Suppress deprecated function notices when implementing the following methods:

• ArrayAccess::offsetExists()
• ArrayAccess::offsetGet()
• ArrayAccess::offsetSet()
• ArrayAccess::offsetUnset()

by adding #[\ReturnTypeWillChange], on the entire codebase.

[justinyost]

Thanks @enricobono noting, we're working on a new 1.2 release that corrects this outstanding issue, that includes this set of fixes here: #13

So I'm going to close this at the moment, but thanks for the PR.

[enricobono]

Thank @justinyost! This is a very good news! 😊
Is there any way we can help?

[justinyost]

Yeah, sure if have the ability/time to check out the branch and review it, that would be always be useful.

You can install it in your consuming project with composer require thewirecutter/paapi5-php-sdk:dev-fully-support-php8.

Otherwise at the moment, I think my branch is about where I wanted it to wind up.

[enricobono]

Downloaded and tested. It's working on my side.
I just have this warning:

local.WARNING: Creation of dynamic property Amazon\ProductAdvertisingAPI\v1\com\amazon\paapi5\v1\auth\SignHelper::$config is deprecated in /var/www/html/vendor/thewirecutter/paapi5-php-sdk/src/com/amazon/paapi5/v1/auth/SignHelper.php on line 54

[justinyost]

@enricobono Thanks so much, I'll get a fix for this incorporated.

[justinyost]

@enricobono Should be resolved with this commit: b2a1d75

[enricobono]

Downloaded and tested. I confirm it's working. No warnings raised 😊
Thanks, Justin!