Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💡 Swap JSDoc for Flow-types functions #16

Merged
merged 10 commits into from
Jan 23, 2018
Merged

💡 Swap JSDoc for Flow-types functions #16

merged 10 commits into from
Jan 23, 2018

Conversation

thibmaek
Copy link
Owner

@thibmaek thibmaek commented Jan 14, 2018 •
edited
Loading

Checkpoints:

  • All tests passing
  • All arguments & return types are typed
  • Types are stripped out from NPM distributed build files
  • Overall type coverage is minimum 60%

Exploration:

  • Custom, reusable types are imported from a types folder
  • Possibly transform typed functions to JSDoc annotated functions in the npm build files
  • Take advantage of flow types like tuples, Iterable, Maybes, Unions, Intersections

@thibmaek thibmaek added this to the v2.0.0 milestone Jan 14, 2018
@thibmaek thibmaek self-assigned this Jan 14, 2018
@thibmaek thibmaek changed the title 💡 Swap JSDoc for Flow-types functions 💡 Swap JSDoc for Flow-types functions Jan 14, 2018
@thibmaek thibmaek merged commit 56eafbc into master Jan 23, 2018
@thibmaek thibmaek deleted the feature/flowtypes branch January 23, 2018 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thibmaek thibmaek

Labels
maintenance
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@thibmaek