Property write node still sending empty value

thinger-io · Apr 12, 2024 · dfb362f · dfb362f
1 parent b800b97
commit dfb362f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@ All notable changes to this project will be documented in this file.
 ### Fixed
 
 - msg placeholders rendering failed when value is null or undefined
+- property write node still sending emtpy payload
 
 ## [1.7.2] - 2024-04-11
 
@@ -299,6 +300,7 @@ All notable changes to this project will be documented in this file.
 
 ## [0.0.6] - 2019-06-20
 
+[1.7.3]: https://github.com/thinger-io/Node-RED/compare/1.7.2...1.7.3
 [1.7.2]: https://github.com/thinger-io/Node-RED/compare/1.7.1...1.7.2
 [1.7.1]: https://github.com/thinger-io/Node-RED/compare/1.7.0...1.7.1
 [1.7.0]: https://github.com/thinger-io/Node-RED/compare/1.6.3...1.7.0

diff --git a/nodes/property-write.html b/nodes/property-write.html
@@ -94,9 +94,11 @@
                             asset.getProperties().then(function(data) {
                                 ThingerDOM.showOptions("property",data,property);
                                 $("#node-input-property").change(function() {
-                                    let propertyValue = JSON.stringify(asset.getPropertyValue($(this).val()),null,'\t');
-                                    if ( propertyValue !== null )
+                                    let propertyValue = asset.getPropertyValue($(this).val());
+                                    if ( propertyValue !== null ) {
+                                        propertyValue = JSON.stringify(propertyValue,null,'\t');
                                         editor.setValue(propertyValue);
+                                    }
                                 });
                             });
                         }

diff --git a/nodes/property-write.js b/nodes/property-write.js
@@ -55,7 +55,7 @@ module.exports = function(RED) {
                         }
                     }
 
-                    if (typeof data === 'undefined' || (typeof data !== 'object' && data.length === 0))
+                    if (typeof data === 'undefined' || data === null || (typeof data !== 'object' && data.length === 0))
                         throw new Error("Property value cannot be empty");
 
                     data = {property: property, value: (typeof data === 'object') ? data : JSON.parse(data)};