Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compiler warning #4

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

hmueller01
Copy link

@hmueller01 hmueller01 commented Jan 12, 2024

PubSubClient.cpp:523:16: warning: comparison of integer expressions of different signedness: 'unsigned int' and 'int' [-Wsign-compare]
  523 |     return (rc == expectedLength);

and replacing all relevant unsigned int by size_t

@hmueller01
Copy link
Author

If you are willing to merge this I should take a look through the examples to update it there as well ...
Sry, at the end it is more than just the compiler warning fix, but there it started after I reviewed the code.

@MathewHDYT
Copy link

@imbeacon Would be nice if this could be merged

@imbeacon imbeacon merged commit 97cc3a5 into thingsboard:master Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants