Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed grpcio version in requirements.txt #979

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Fixed grpcio version in requirements.txt #979

merged 1 commit into from
Nov 4, 2022

Conversation

samson0v
Copy link
Contributor

@samson0v samson0v commented Nov 4, 2022

No description provided.

@imbeacon imbeacon merged commit 5d0cb21 into thingsboard:master Nov 4, 2022
@helsmore
Copy link

helsmore commented Nov 4, 2022

@samson0v It looks like the file you've changed, requirements.txt in the repo root directory, doesn't get used when building the Docker image (if I've understood the Docker build instructions in the TB docs correctly).

From https://thingsboard.io/docs/iot-gateway/install/docker-installation/#build-local-docker-image:

  1. Copy thingsboard_gateway/ directory to docker/ directory.
  2. Build the Docker image

It seems that because you only copy this single directory from the repo root the Docker build process will end up using docker/requirements.txt not requirements.txt, this would mean that the change you've just made would not apply to the Docker image build, is that not the case?

What do you think?

cc: @imbeacon

@helsmore
Copy link

helsmore commented Nov 4, 2022

In any case it appears there are some significant differences between requirements.txt and docker/requirements.txt. It's not clear why there's two different files, you could just delete docker/requirements.txt from the repo and copy requirements.txt at the same time as the thingsboard_gateway directory (whilst preparing for Docker build) unless there's some reason that you need different packages installed when running inside the Docker container compared to other deployment methods.

@helsmore
Copy link

@imbeacon @samson0v

Can you have a look at my comments above please? I think either the fix you made changed the wrong file or the docs are misleading.

Many thanks.

@samson0v
Copy link
Contributor Author

samson0v commented Dec 1, 2022

@helsmore done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] V3.2 Docker Image Fails on Raspberry Pi When Using Connectors With gRPC Transport
3 participants