Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove [Infix] operations #40

Merged
merged 1 commit into from
Jan 8, 2022
Merged

remove [Infix] operations #40

merged 1 commit into from
Jan 8, 2022

Conversation

rgrinberg
Copy link
Collaborator

They are not standard across OCaml libraries and the convenience offered
is very minor.

@rgrinberg
remove [Infix] operations
961abb4 
They are not standard across OCaml libraries and the convenience offered
is very minor.

ps-id: 3B7E8656-2EA0-4BE6-9888-DA8AC62A932D
@rgrinberg rgrinberg requested a review from thizanne January 8, 2022 20:42
thizanne
thizanne approved these changes Jan 8, 2022
View reviewed changes
Copy link
Owner

@thizanne thizanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, I believe these were modelled from batteries. I'm not sure the batteries ones see some use anyway. We can easily add them back later if desired (possibly with the more modern syntax).

@thizanne thizanne merged commit 2d5e536 into master Jan 8, 2022
@rgrinberg rgrinberg deleted the ps/rr/remove__infix__operations branch January 9, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thizanne thizanne thizanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgrinberg @thizanne