Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing spaces #382

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Conversation

fingolfin
Copy link
Contributor

This reflects the settings in .editorconfig: due to those, whenever
I open and edit a file in Hecke.jl, as a side effect all trailing spaces
are removed, which unnecessarily blows up my commits (or I have to manually
remove those changes again).

So, let's get rid of them in one swoop now; new ones should hopefully not
be added as long as everyone uses an editor which honors .editorconfig.

This reflects the settings in `.editorconfig`: due to those, whenever
I open and edit a file in Hecke.jl, as a side effect all trailing spaces
are removed, which unnecessarily blows up my commits (or I have to manually
remove those changes again).

So, let's get rid of them in one swoop now; new ones should hopefully not
be added as long as everyone uses an editor which honors `.editorconfig`.
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #382 (c52ae51) into master (6463533) will increase coverage by 0.01%.
The diff coverage is 68.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
+ Coverage   66.26%   66.27%   +0.01%     
==========================================
  Files         295      295              
  Lines       89049    89049              
==========================================
+ Hits        59004    59015      +11     
+ Misses      30045    30034      -11     
Impacted Files Coverage Δ
src/AlgAss/AlgQuat.jl 0.00% <0.00%> (ø)
src/AlgAss/Elem.jl 81.48% <ø> (ø)
src/AlgAss/Types.jl 73.48% <0.00%> (ø)
src/AlgAssAbsOrd/Conjugacy/Conjugacy.jl 60.81% <0.00%> (ø)
src/AlgAssAbsOrd/Conjugacy/Husert.jl 91.37% <ø> (ø)
src/AlgAssAbsOrd/Conjugacy/Lifting.jl 5.84% <0.00%> (ø)
src/AlgAssAbsOrd/Conjugacy/Random.jl 0.00% <ø> (ø)
src/AlgAssAbsOrd/PIP.jl 18.20% <0.00%> (ø)
src/AlgAssAbsOrd/PicardGroup.jl 85.50% <ø> (+0.31%) ⬆️
src/Assertions.jl 58.33% <ø> (ø)
... and 206 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6463533...c52ae51. Read the comment docs.

@thofma thofma merged commit 0a50220 into thofma:master Aug 18, 2021
@fingolfin fingolfin deleted the mh/remove-trailing-spaces branch August 18, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants