Skip to content

Commit

Permalink
Format tests/language/n*.
Browse files Browse the repository at this point in the history
A lot of unspecified errors got filled in this time.

Change-Id: I88e728499da1b591ee1f6de1749f35182a6c9996
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408887
Auto-Submit: Bob Nystrom <[email protected]>
Commit-Queue: Bob Nystrom <[email protected]>
Reviewed-by: Lasse Nielsen <[email protected]>
  • Loading branch information
munificent authored and Commit Queue committed Feb 11, 2025
1 parent dbaf041 commit 13ce8ba
Show file tree
Hide file tree
Showing 188 changed files with 2,711 additions and 2,644 deletions.
150 changes: 106 additions & 44 deletions tests/language/named_arguments_anywhere/all_kinds_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ X evaluate<X>(X x) {
}

void runAndCheckEvaluationOrder(
List<Object?> expectedArguments, void Function() functionToRun) {
List<Object?> expectedArguments,
void Function() functionToRun,
) {
arguments.clear();
functionToRun();
Expect.listEquals(expectedArguments, arguments);
Expand All @@ -30,19 +32,19 @@ class A {
}

A.redir1()
: this(evaluate(1), evaluate("2"), z: evaluate(false), w: evaluate(3.14));
: this(evaluate(1), evaluate("2"), z: evaluate(false), w: evaluate(3.14));

A.redir2()
: this(evaluate(1), z: evaluate(false), evaluate("2"), w: evaluate(3.14));
: this(evaluate(1), z: evaluate(false), evaluate("2"), w: evaluate(3.14));

A.redir3()
: this(z: evaluate(false), evaluate(1), evaluate("2"), w: evaluate(3.14));
: this(z: evaluate(false), evaluate(1), evaluate("2"), w: evaluate(3.14));

A.redir4()
: this(w: evaluate(3.14), evaluate(1), evaluate("2"), z: evaluate(false));
: this(w: evaluate(3.14), evaluate(1), evaluate("2"), z: evaluate(false));

A.redir5()
: this(evaluate(1), w: evaluate(3.14), evaluate("2"), z: evaluate(false));
: this(evaluate(1), w: evaluate(3.14), evaluate("2"), z: evaluate(false));

A.redir6() : this(evaluate(1), w: evaluate(3.14), evaluate("2"));

Expand Down Expand Up @@ -212,49 +214,74 @@ test(dynamic d, Function f, A a) {

// InstanceGetterInvocation.
runAndCheckEvaluationOrder([1, "2", false, 3.14], () {
a.property(evaluate(1), evaluate("2"),
z: evaluate(false), w: evaluate(3.14));
a.property(
evaluate(1),
evaluate("2"),
z: evaluate(false),
w: evaluate(3.14),
);
});
runAndCheckEvaluationOrder([1, false, "2", 3.14], () {
a.property(
evaluate(1), z: evaluate(false), evaluate("2"), w: evaluate(3.14));
evaluate(1),
z: evaluate(false),
evaluate("2"),
w: evaluate(3.14),
);
});
runAndCheckEvaluationOrder([false, 1, "2", 3.14], () {
a.property(
z: evaluate(false), evaluate(1), evaluate("2"), w: evaluate(3.14));
z: evaluate(false),
evaluate(1),
evaluate("2"),
w: evaluate(3.14),
);
});
runAndCheckEvaluationOrder([3.14, 1, "2", false], () {
a.property(
w: evaluate(3.14), evaluate(1), evaluate("2"), z: evaluate(false));
w: evaluate(3.14),
evaluate(1),
evaluate("2"),
z: evaluate(false),
);
});
runAndCheckEvaluationOrder([1, 3.14, "2", false], () {
a.property(
evaluate(1), w: evaluate(3.14), evaluate("2"), z: evaluate(false));
evaluate(1),
w: evaluate(3.14),
evaluate("2"),
z: evaluate(false),
);
});
runAndCheckEvaluationOrder([1, 3.14, "2"], () {
a.property(evaluate(1), w: evaluate(3.14), evaluate("2"));
});

// InstanceInvocation.
runAndCheckEvaluationOrder([a, 1, "2", false, 3.14], () {
evaluate(a)
.bar(evaluate(1), evaluate("2"), z: evaluate(false), w: evaluate(3.14));
evaluate(
a,
).bar(evaluate(1), evaluate("2"), z: evaluate(false), w: evaluate(3.14));
});
runAndCheckEvaluationOrder([a, 1, false, "2", 3.14], () {
evaluate(a)
.bar(evaluate(1), z: evaluate(false), evaluate("2"), w: evaluate(3.14));
evaluate(
a,
).bar(evaluate(1), z: evaluate(false), evaluate("2"), w: evaluate(3.14));
});
runAndCheckEvaluationOrder([a, false, 1, "2", 3.14], () {
evaluate(a)
.bar(z: evaluate(false), evaluate(1), evaluate("2"), w: evaluate(3.14));
evaluate(
a,
).bar(z: evaluate(false), evaluate(1), evaluate("2"), w: evaluate(3.14));
});
runAndCheckEvaluationOrder([a, 3.14, 1, "2", false], () {
evaluate(a)
.bar(w: evaluate(3.14), evaluate(1), evaluate("2"), z: evaluate(false));
evaluate(
a,
).bar(w: evaluate(3.14), evaluate(1), evaluate("2"), z: evaluate(false));
});
runAndCheckEvaluationOrder([a, 1, 3.14, "2", false], () {
evaluate(a)
.bar(evaluate(1), w: evaluate(3.14), evaluate("2"), z: evaluate(false));
evaluate(
a,
).bar(evaluate(1), w: evaluate(3.14), evaluate("2"), z: evaluate(false));
});
runAndCheckEvaluationOrder([a, 1, 3.14, "2"], () {
evaluate(a).bar(evaluate(1), w: evaluate(3.14), evaluate("2"));
Expand Down Expand Up @@ -302,24 +329,44 @@ test(dynamic d, Function f, A a) {

// Redirecting factory constructors.
runAndCheckEvaluationOrder([1, "2", false, 3.14], () {
A.redirFactory(evaluate(1), evaluate("2"),
z: evaluate(false), w: evaluate(3.14));
A.redirFactory(
evaluate(1),
evaluate("2"),
z: evaluate(false),
w: evaluate(3.14),
);
});
runAndCheckEvaluationOrder([1, false, "2", 3.14], () {
A.redirFactory(
evaluate(1), z: evaluate(false), evaluate("2"), w: evaluate(3.14));
evaluate(1),
z: evaluate(false),
evaluate("2"),
w: evaluate(3.14),
);
});
runAndCheckEvaluationOrder([false, 1, "2", 3.14], () {
A.redirFactory(
z: evaluate(false), evaluate(1), evaluate("2"), w: evaluate(3.14));
z: evaluate(false),
evaluate(1),
evaluate("2"),
w: evaluate(3.14),
);
});
runAndCheckEvaluationOrder([3.14, 1, "2", false], () {
A.redirFactory(
w: evaluate(3.14), evaluate(1), evaluate("2"), z: evaluate(false));
w: evaluate(3.14),
evaluate(1),
evaluate("2"),
z: evaluate(false),
);
});
runAndCheckEvaluationOrder([1, 3.14, "2", false], () {
A.redirFactory(
evaluate(1), w: evaluate(3.14), evaluate("2"), z: evaluate(false));
evaluate(1),
w: evaluate(3.14),
evaluate("2"),
z: evaluate(false),
);
});
runAndCheckEvaluationOrder([1, 3.14, "2"], () {
A.redirFactory(evaluate(1), w: evaluate(3.14), evaluate("2"));
Expand Down Expand Up @@ -370,42 +417,57 @@ class Test extends A {
Test() : super(1, "2", z: false, w: 3.14);

Test.super1()
: super(evaluate(1), evaluate("2"),
z: evaluate(false), w: evaluate(3.14));
: super(evaluate(1), evaluate("2"), z: evaluate(false), w: evaluate(3.14));
Test.super2()
: super(
evaluate(1), z: evaluate(false), evaluate("2"), w: evaluate(3.14));
: super(evaluate(1), z: evaluate(false), evaluate("2"), w: evaluate(3.14));
Test.super3()
: super(
z: evaluate(false), evaluate(1), evaluate("2"), w: evaluate(3.14));
: super(z: evaluate(false), evaluate(1), evaluate("2"), w: evaluate(3.14));
Test.super4()
: super(
w: evaluate(3.14), evaluate(1), evaluate("2"), z: evaluate(false));
: super(w: evaluate(3.14), evaluate(1), evaluate("2"), z: evaluate(false));
Test.super5()
: super(
evaluate(1), w: evaluate(3.14), evaluate("2"), z: evaluate(false));
: super(evaluate(1), w: evaluate(3.14), evaluate("2"), z: evaluate(false));
Test.super6() : super(evaluate(1), w: evaluate(3.14), evaluate("2"));

test() {
runAndCheckEvaluationOrder([1, "2", false, 3.14], () {
super.bar(evaluate(1), evaluate("2"),
z: evaluate(false), w: evaluate(3.14));
super.bar(
evaluate(1),
evaluate("2"),
z: evaluate(false),
w: evaluate(3.14),
);
});
runAndCheckEvaluationOrder([1, false, "2", 3.14], () {
super.bar(
evaluate(1), z: evaluate(false), evaluate("2"), w: evaluate(3.14));
evaluate(1),
z: evaluate(false),
evaluate("2"),
w: evaluate(3.14),
);
});
runAndCheckEvaluationOrder([false, 1, "2", 3.14], () {
super.bar(
z: evaluate(false), evaluate(1), evaluate("2"), w: evaluate(3.14));
z: evaluate(false),
evaluate(1),
evaluate("2"),
w: evaluate(3.14),
);
});
runAndCheckEvaluationOrder([3.14, 1, "2", false], () {
super.bar(
w: evaluate(3.14), evaluate(1), evaluate("2"), z: evaluate(false));
w: evaluate(3.14),
evaluate(1),
evaluate("2"),
z: evaluate(false),
);
});
runAndCheckEvaluationOrder([1, 3.14, "2", false], () {
super.bar(
evaluate(1), w: evaluate(3.14), evaluate("2"), z: evaluate(false));
evaluate(1),
w: evaluate(3.14),
evaluate("2"),
z: evaluate(false),
);
});
runAndCheckEvaluationOrder([1, 3.14, "2"], () {
super.bar(evaluate(1), w: evaluate(3.14), evaluate("2"));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ void registerTypeArgument<X>() {
}

void runAndCheckForTypeArgument(
Type expectedArgument, void Function() functionToRun) {
Type expectedArgument,
void Function() functionToRun,
) {
argument = null;
functionToRun();
Expect.equals(expectedArgument, argument);
Expand Down
4 changes: 1 addition & 3 deletions tests/language/new/create_unresolved_type_runtime_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,4 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

main() {

}
main() {}
5 changes: 0 additions & 5 deletions tests/language/new/expression_type_args_runtime_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,12 @@
class A<T> {
// Can't instantiate type parameter (within static or instance method).



// OK when used within instance method, but not in static method.
m3() => new A<T>();

}

main() {
A a = new A();


a.m3();

}
12 changes: 0 additions & 12 deletions tests/language/new/prefix_runtime_test.dart

This file was deleted.

4 changes: 1 addition & 3 deletions tests/language/new/statement_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ class A {
static int c = -1;
static int d = -1;

A(int x, int y)
: a = x,
b = y {
A(int x, int y) : a = x, b = y {
A.c = x;
A.d = y;
}
Expand Down
Loading

0 comments on commit 13ce8ba

Please sign in to comment.