Skip to content

Commit

Permalink
[test] Unskip many tests in reload stress testing.
Browse files Browse the repository at this point in the history
Change-Id: I9ef008b00bb043b210d18659a49ee07fde081f67
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/409202
Commit-Queue: Ryan Macnak <[email protected]>
Reviewed-by: Siva Annamalai <[email protected]>
  • Loading branch information
rmacnak-google authored and Commit Queue committed Feb 11, 2025
1 parent 413d9e9 commit 5c6f92f
Show file tree
Hide file tree
Showing 7 changed files with 4 additions and 56 deletions.
4 changes: 1 addition & 3 deletions tests/corelib/corelib.status
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,4 @@ regexp/global_test: Skip # Issue 21709
regexp/pcre_test: Slow, Pass

[ $hot_reload || $hot_reload_rollback ]
bigint_parse_radix_test: Skip # Issue 31659. Issue 34361.
bigint_test: Skip # Issue 31659
integer_parsed_mul_div_vm_test: Slow, Pass # Slow
bigint_test: SkipSlow
2 changes: 0 additions & 2 deletions tests/language/language.status
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,4 @@ function_type/*: Skip # Needs checked mode.
identifier/built_in_type_annotation_test/set: Crash # Not supported by legacy VM front-end.

[ $hot_reload || $hot_reload_rollback ]
macros/introspect/declaration_introspect_cycle_failure_test: Skip # Issue 54779
regress/regress22780_test/01: Crash # Issue 29094
vm/optimized_stacktrace_test: Slow, Pass
6 changes: 0 additions & 6 deletions tests/language/language_kernel.status
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,6 @@ vm/no_such_args_error_message_vm_test: SkipByDesign # Looks for function name in
vm/no_such_method_error_message_callable_vm_test: SkipByDesign # Expects unobfuscated method names
vm/no_such_method_error_message_vm_test: SkipByDesign # Looks for unobfuscated name in error message

[ $compiler == dartk && $mode == debug && ($hot_reload || $hot_reload_rollback) ]
enum/duplicate_test/02: Crash # Issue 34606
enum/duplicate_test/none: Crash # Issue 34606
enum/private_test/01: Crash # Issue 34606
unsorted/inference_enum_list_test: Skip # Issue 35885

[ $compiler == dartk && $mode == product && $runtime == vm ]
vm/lazy_async_exception_stack2_test: SkipByDesign
vm/lazy_async_exception_stack_test: SkipByDesign
Expand Down
4 changes: 0 additions & 4 deletions tests/lib/lib.status
Original file line number Diff line number Diff line change
Expand Up @@ -187,12 +187,9 @@ isolate/static_function_test: Skip # Isolate.spawnUri
isolate/unresolved_ports_test: Skip # Isolate.spawnUri

[ $hot_reload || $hot_reload_rollback ]
convert/chunked_conversion_utf88_test: SkipSlow
convert/utf85_test: SkipSlow
isolate/deferred_in_isolate2_test: Crash # Requires deferred libraries
isolate/deferred_in_isolate_test: Crash # Requires deferred libraries
isolate/issue_21398_parent_isolate2_test: Crash # Requires deferred libraries
isolate/spawn_uri_nested_vm_test: Crash # Issue 28192
mirrors/closurization_equivalence_test: SkipByDesign # Method equality
mirrors/deferred_constraints_constants_test: Crash # Requires deferred libraries
mirrors/deferred_mirrors_metadata_test: Crash # Deferred loading
Expand All @@ -203,4 +200,3 @@ mirrors/library_import_deferred_loading_test: Crash # Deferred loading
mirrors/library_imports_deferred_test: Crash # Deferred loading
mirrors/load_library_test: Crash # Deferred loading
mirrors/typedef_deferred_library_test: Crash # Deferred loading
typed_data/zeroed_allocation_test: SkipSlow
12 changes: 0 additions & 12 deletions tests/lib/lib_kernel.status
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ js/*: Skip # TODO(ahe): Make dart:js available.
[ $arch == x64 && $compiler == dartk && $mode == debug && $runtime == vm ]
mirrors/invocation_fuzz_test: Skip # Because it times out, issue 29439.

[ $arch == x64 && ($hot_reload || $hot_reload_rollback) ]
convert/base64_test/01: Crash # http://dartbug.com/35948

[ $builder_tag == optimization_counter_threshold && $compiler == dartk ]
mirrors/invocation_fuzz_test/emptyarray: Crash # Flaky on vm-kernel-optcounter-threshold-linux-release-x64, bug #31838
mirrors/invocation_fuzz_test/false: Crash # Flaky on vm-kernel-optcounter-threshold-linux-release-x64, bug #31838
Expand All @@ -32,9 +29,6 @@ isolate/spawn_uri_nested_vm_test: Skip # Timeout, Issue 33385
[ $compiler == dartk && $mode == debug && $runtime == vm ]
mirrors/other_declarations_location_test: Crash # Issue 33325 (assertion error, TypeParameter not having position).

[ $compiler == dartk && $mode == debug && $hot_reload_rollback ]
isolate/message3_test/constList_identical: Skip # Timeout

# ===== dartk + vm status lines =====
[ $compiler == dartk && $runtime == vm ]
html/*: SkipByDesign # dart:html not supported on VM.
Expand All @@ -45,14 +39,8 @@ isolate/static_function_test: Skip # Times out. Issue 31855. CompileTimeError. I
mirrors/invocation_fuzz_test/smi: Crash
mirrors/metadata_allowed_values_test/16: Skip # Flaky, crashes.

[ $compiler == dartk && $hot_reload_rollback ]
isolate/pause_test: Skip # Timeout

[ $compiler == dartk && ($hot_reload || $hot_reload_rollback) ]
isolate/message4_test: Crash # Timeout and sporadic crash (issue 33824)
mirrors/dynamic_load_test: Skip # Reload has an effect similar to deleting the dynamically loaded library
mirrors/immutable_collections_test: Pass, Slow
mirrors/mirrors_reader_test: Pass, Slow

[ $compiler == dartkp && $mode == debug && $runtime == dart_precompiled ]
isolate/static_function_test: Skip # Flaky (https://github.com/dart-lang/sdk/issues/30063).
Expand Down
4 changes: 0 additions & 4 deletions tests/standalone/standalone.status
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,4 @@ io/socket_many_connections_test: Skip # This test fails with "Too many open file
deferred_transitive_import_error_test: Skip

[ $hot_reload || $hot_reload_rollback ]
io/addlatexhash_test: Crash # Issue 31252
io/many_directory_operations_test: SkipSlow
io/many_file_operations_test: SkipSlow
package/*: SkipByDesign # Launches VMs in interesting ways.
typed_data_isolate_test: SkipSlow
28 changes: 3 additions & 25 deletions tests/standalone/standalone_kernel.status
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ map_insert_remove_oom_test: Skip # Heap limit too low.
[ $compiler == dartk && $mode == debug && $runtime == vm ]
io/file_lock_test: Slow, Pass

[ $compiler == dartk && $mode == debug && $hot_reload ]
io/web_socket_ping_test: Crash

[ $compiler == dartk && $runtime == vm ]
no_support_debugger_test: Skip # kernel-service snapshot not compatible with flag disabled

Expand All @@ -26,14 +23,6 @@ io/dart_std_io_pipe_test: Slow, Pass
io/secure_builtin_roots_test: Skip # Issues 32137 and 32138.
map_insert_remove_oom_test: Skip # Heap limit too low.

[ $compiler == dartk && $hot_reload ]
io/http_no_reason_phrase_test: Crash
io/http_outgoing_size_test: Crash

[ $compiler == dartk && $hot_reload_rollback ]
io/directory_chdir_test: Skip # Timeout
io/echo_server_stream_test: Slow, Pass

# Enabling of dartk for sim{arm,arm64} revealed these test failures, which
# are to be triaged. Isolate tests are skipped on purpose due to the usage of
# batch mode.
Expand All @@ -43,20 +32,6 @@ io/file_lock_test: Slow, Pass
io/http_bind_test: Slow, Pass
map_insert_remove_oom_test: Skip # Heap limit too low.

[ $compiler == dartk && ($hot_reload || $hot_reload_rollback) ]
io/addlatexhash_test: Skip # Timeout
io/http_advanced_test: Skip # Timeout
io/http_auth_digest_test: Crash
io/http_auth_test: Skip # Timeout
io/http_proxy_advanced_test: Skip # Timeout
io/http_read_test: Skip # Timeout
io/pipe_server_test: Skip # Timeout
io/socket_close_test: Skip # Timeout
io/socket_many_connections_test: Skip # Timeout
io/web_socket_compression_test: Skip # Timeout
io/web_socket_test: Skip # Timeout
regress_52715_test/measure: Skip # kernel-service interferes with measuring RSS

[ $compiler == dartkp && $mode == debug && $runtime == dart_precompiled ]
io/raw_socket_test: Crash
io/socket_finalizer_test: Crash
Expand Down Expand Up @@ -92,3 +67,6 @@ check_for_aot_snapshot_jit_test: SkipByDesign # Test relies on paths, requires J

[ $sanitizer == asan || $sanitizer == lsan || $sanitizer == msan || $sanitizer == tsan ]
regress_52715_test/measure: Skip # Shadow memory and scudo quarantine interfere with measuring RSS

[ $hot_reload || $hot_reload_rollback ]
regress_52715_test/measure: Skip # kernel-service interferes with measuring RSS

0 comments on commit 5c6f92f

Please sign in to comment.