Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

break handler tablers based on namespace #680

Merged
merged 1 commit into from
Jan 23, 2023
Merged

break handler tablers based on namespace #680

merged 1 commit into from
Jan 23, 2023

Conversation

KPostOffice
Copy link
Member

bottleneck due to argo workflow limit which kept user workflows in backend from getting scheduled due to middletier workflow limit

Signed-off-by: Kevin [email protected]

Related Issues and Dependencies

fixes: #673

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

@KPostOffice
Copy link
Member Author

/hold

@sesheta sesheta added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 1, 2022
@sesheta sesheta requested review from goern and harshad16 December 1, 2022 23:30
@KPostOffice KPostOffice force-pushed the consumer-by-wfnamespace branch 4 times, most recently from 24546a7 to 0cb4c15 Compare December 5, 2022 22:25
@KPostOffice
Copy link
Member Author

/test thoth-mypy-py38

@KPostOffice KPostOffice force-pushed the consumer-by-wfnamespace branch from 0cb4c15 to c27d36b Compare December 5, 2022 22:35
@KPostOffice
Copy link
Member Author

/deploy

@KPostOffice KPostOffice force-pushed the consumer-by-wfnamespace branch from c27d36b to 87d171a Compare December 6, 2022 20:28
@KPostOffice
Copy link
Member Author

/deploy

@KPostOffice KPostOffice force-pushed the consumer-by-wfnamespace branch from 87d171a to f792fa2 Compare December 6, 2022 21:44
@sesheta sesheta added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 6, 2022
@KPostOffice
Copy link
Member Author

/deploy

@KPostOffice
Copy link
Member Author

This is ready for review

@KPostOffice
Copy link
Member Author

/unhold

@sesheta sesheta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2022
@goern goern added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2022
@KPostOffice KPostOffice force-pushed the consumer-by-wfnamespace branch from f792fa2 to 7cbd8e1 Compare January 6, 2023 17:49
harshad16
harshad16 reviewed Jan 20, 2023
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
really like the solution of having multiple investigator consumers based on the type of message (in this case namespace)

@KPostOffice
break handler tablers based on namespace
5ad070d 
bottleneck due to argo workflow limit which kept user workflows
in backend from getting scheduled due to middletier workflow limit

Signed-off-by: Kevin <[email protected]>
@KPostOffice KPostOffice force-pushed the consumer-by-wfnamespace branch from 7cbd8e1 to 5ad070d Compare January 20, 2023 19:12
@sesheta sesheta added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 20, 2023
@harshad16
Copy link
Member

/deploy

@KPostOffice KPostOffice removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2023
harshad16
harshad16 approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for the work 👍

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2023
@sesheta
Copy link
Member

sesheta commented Jan 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2023
@sesheta sesheta merged commit fb4d292 into thoth-station:master Jan 23, 2023
@harshad16 harshad16 mentioned this pull request Jan 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 harshad16 approved these changes

@goern goern Awaiting requested review from goern

Assignees

@harshad16 harshad16

@KPostOffice KPostOffice

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use multiple consumer based on different topics
4 participants
@KPostOffice @harshad16 @sesheta @goern