Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation for PR labels for version manager #1073

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

KPostOffice
Copy link
Member

I added configuration documentation for the ability to trigger
version manager directly from a PR using labels. I also added it
to the example configuration for the version manager.

Related Issues and Dependencies

closes: #1010

This introduces a breaking change

  • Yes
  • No

@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 21, 2022
@sesheta sesheta requested review from harshad16 and pacospace June 21, 2022 19:13
@KPostOffice KPostOffice force-pushed the docs4versionmanager branch 5 times, most recently from 5f3f88d to 377400a Compare June 21, 2022 19:25
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sesheta sesheta added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 21, 2022
@KPostOffice KPostOffice force-pushed the docs4versionmanager branch from 377400a to f9ab93b Compare June 21, 2022 19:27
@sesheta sesheta removed the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2022
I added configuration documentation for the ability to trigger
version manager directly from a PR using labels. I also added it
to the example configuration for the version manager.
@KPostOffice KPostOffice force-pushed the docs4versionmanager branch from f9ab93b to 5042936 Compare June 21, 2022 19:29
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

identation changes required

docs/managers/version.rst Show resolved Hide resolved
@sesheta sesheta removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2022
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2022
@sesheta
Copy link
Member

sesheta commented Jun 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2022
@sesheta sesheta merged commit 3ea640b into thoth-station:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VersionManager Labeled PRs Documentation
3 participants