Fix: To check if kebechet's advise manager is working on all overlays #1096
Conversation
sesheta
added
the
size/S
shreekarSS
force-pushed
the
overlays
branch
2 times, most recently
from
695ce9e to
b69be4c
Compare
| self.runtime_environment = _runtime_env_name_from_advise_response( | ||
| res[0] | ||
| ) | ||
| to_ret = False | ||
| if res[1] is False: | ||
| _LOGGER.info("Advise succeeded") | ||
| self._write_advise(res[0]) | ||
| res[0].update({"document_id": analysis_id}) | ||
| file_path = os.path.join( | ||
| overlays_dir, str(self.runtime_environment), "Pipfile.lock" |
There was a problem hiding this comment.
Hey, what happens if there is no overlays dir? overlays_dir will still be an empty string. This should looks something like:
file_path = os.path.join(overlays_dir, self.runtime_environment, "Pipfile.lock") if overlays_dir else "Pipfile.lock"
There was a problem hiding this comment.
Ack, thanks for pointing out
Signed-off-by: Shreekara <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KPostOffice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
approved
| opened_merge = self._open_merge_request( | ||
| branch_name, labels, ["Pipfile.lock"], res[0].get("metadata") | ||
| branch_name, labels, [file_path], res[0] |
There was a problem hiding this comment.
Wouldnt this res[0] put a lot of info on the pr ?
There was a problem hiding this comment.
I'm just taking document_id from the dict, https://github.com/shreekarSS/kebechet/blob/b405c224bea8763c94699c180ecf66b2aac18791/kebechet/managers/thoth_advise/thoth_advise.py#L143
Related Issues and Dependencies
Fixes: thoth-station/ps-nlp#151
Fixes: thoth-station/support#247
Fixes: thoth-station/support#248
Fixes: #1094
Fixes: thoth-station/support#251
…
Description
Fixed referencing incorrect dict keys and Piplock file path