Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make update manager work with overlays #770

Merged
merged 1 commit into from
Jul 27, 2021
Merged

make update manager work with overlays #770

merged 1 commit into from
Jul 27, 2021

Conversation

KPostOffice
Copy link
Member

Related Issues and Dependencies

#715

This introduces a breaking change

  • Yes
  • No

I need to test this on jupyternb-requirements or some repo with overlays to see if the feature is working. It is still working on flat repos though.

@sesheta sesheta added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2021
@sesheta
Copy link
Member

sesheta commented Jul 23, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sesheta sesheta requested review from harshad16 and pacospace July 23, 2021 16:20
@sesheta sesheta added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 23, 2021
@KPostOffice KPostOffice marked this pull request as ready for review July 23, 2021 18:08
@sesheta sesheta removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2021
@KPostOffice KPostOffice force-pushed the issue715-update branch 2 times, most recently from 47e8a70 to 30d5a1f Compare July 23, 2021 19:11
pacospace
pacospace reviewed Jul 26, 2021
View reviewed changes
kebechet/managers/update/messages.py Outdated
@@ -156,8 +156,7 @@

Make sure your `Pipfile` or `requirements.in` or `requirements-dev.in` is placed in the root of your Git repository.

/kind feature
/priority important-soon
/kind feature /priority important-soon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be on two different lines or they will all be considered /kind I think

pacospace
pacospace reviewed Jul 26, 2021
View reviewed changes
kebechet/managers/update/update.py Outdated
comment=ISSUE_CLOSE_COMMENT.format(sha=self.sha),
)
with cwd(thoth_config.get_overlays_directory(e)):
print(os.getcwd())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

print?

pacospace
pacospace reviewed Jul 27, 2021
View reviewed changes
Copy link
Contributor

@pacospace pacospace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 💯 👏🏼

harshad16
harshad16 approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thanks 👍

@pacospace
Copy link
Contributor

Related Issues and Dependencies

#715

This introduces a breaking change

  • Yes
  • No

I need to test this on jupyternb-requirements or some repo with overlays to see if the feature is working. It is still working on flat repos though.

best repo could be the ps- repos that have overlays @KPostOffice

@sesheta
Copy link
Member

sesheta commented Jul 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, pacospace

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2021
@sesheta sesheta merged commit 235190d into thoth-station:master Jul 27, 2021
@KPostOffice KPostOffice deleted the issue715-update branch December 15, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 harshad16 approved these changes

@pacospace pacospace pacospace approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KPostOffice @sesheta @pacospace @harshad16