Fix markdown format for table rows #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesheta
added
the
size/XS
KPostOffice
reviewed
Sep 21, 2021
kebechet/managers/update/update.py
Outdated
| @@ -703,7 +703,9 @@ def _generate_update_body(self, outdated: dict) -> str: | |||
| details.get("new_version"), | |||
| details.get("dev"), | |||
| ) | |||
| package_name_rows += f"**{package}**|{old_version}|{new_version}|{is_dev}\n" | |||
| package_name_rows += ( | |||
| f"|**{package}**|{old_version}|{new_version}|{is_dev}\n" | |||
There was a problem hiding this comment.
Suggested change
| f"|**{package}**|{old_version}|{new_version}|{is_dev}\n" | |
| f"|**{package}**|{old_version}|{new_version}|{is_dev}|\n" |
There was a problem hiding this comment.
heh, good point, thanks! I'll add that trailing pipe too
Add leading and traling | chars to clarify markdown for table rows Signed-off-by: Pep Turró Mauri <[email protected]>
codificat
force-pushed
the
format-update-rows
branch
from
ff00639 to
4bd0f86
Compare
KPostOffice
approved these changes
Sep 21, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16, KPostOffice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues and Dependencies
#822
This introduces a breaking change
This Pull Request implements
Fix the markdown formatting of the package rows in the table within update PRs.
Description
The fix in #823 fixes the formatting of the header of the table in the reported issues by adding the missing leading
|.This PR adds that pipe char to the rows that go after the header, i.e. the rest of the table, formed by the list of packages to update.