Remove destination table from BigQuery config #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesheta
added
the
size/XS
mayaCostantini
force-pushed
the
remove-destination-table
branch
from
f2f863c to
fa7d824
Compare
codificat
requested changes
Jun 15, 2022
mayaCostantini
force-pushed
the
remove-destination-table
branch
from
fa7d824 to
156b513
Compare
|
@codificat thanks for the review, I updated the PR description and squashed the commits |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a breaking change
This should yield a new module release
This Pull Request implements
Remove BigQuery destination table in
pypi-downloadshandler. Writing to a destination table does not seem to have any utility here and might be the source of a lot of traffic generated on the BigQuery API (~6000 calls to thegoogle.cloud.bigquery.v2.JobService.InsertJobAPI method).