Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Ubi8 py39 #197

Merged
merged 8 commits into from
Jul 20, 2021
Merged

add Ubi8 py39 #197

merged 8 commits into from
Jul 20, 2021

Conversation

goern
Copy link
Member

@goern goern commented Jul 16, 2021

Related Issues and Dependencies

ssia

This introduces a breaking change

  • Yes
  • No

@sesheta sesheta added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2021
@sesheta sesheta requested review from KPostOffice and pacospace July 16, 2021 20:54
@sesheta
Copy link
Member

sesheta commented Jul 16, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sesheta sesheta added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 16, 2021
goern added 2 commits July 16, 2021 23:03
@goern
⬆️ update github templates
d5170f7 
Signed-off-by: Christoph Görn <[email protected]>
@goern
⬆️ created r.txt for ubi8-py39
31f86eb 
Signed-off-by: Christoph Görn <[email protected]>
@goern goern changed the title WIP add Ubi8 py39 add Ubi8 py39 Jul 17, 2021
@goern goern marked this pull request as ready for review July 17, 2021 18:37
@goern goern requested review from fridex and sesheta as code owners July 17, 2021 18:37
@sesheta sesheta removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2021
@goern
Copy link
Member Author

goern commented Jul 18, 2021

@harshad16 @fridex I fiddled around with the Dockerfile in ubi8-py39, please check if my changes are ok, thx 🙏

@goern goern mentioned this pull request Jul 18, 2021
Closed
5 tasks
@goern
🐛 fix pre-commit fails
5b3faea 
Signed-off-by: Christoph Görn <[email protected]>
harshad16
harshad16 approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thanks 💯

@harshad16 harshad16 merged commit f953a78 into thoth-station:master Jul 20, 2021
@sesheta
Copy link
Member

sesheta commented Jul 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 harshad16 approved these changes

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

@pacospace pacospace Awaiting requested review from pacospace

@fridex fridex Awaiting requested review from fridex

@sesheta sesheta Awaiting requested review from sesheta sesheta is a code owner

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goern @sesheta @harshad16