Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all requirements.txt to have new thamos version #199

Merged
merged 2 commits into from
Jul 26, 2021

Conversation

pacospace
Copy link
Contributor

Signed-off-by: Francesco Murdaca [email protected]

@pacospace pacospace requested a review from harshad16 July 23, 2021 08:19
@sesheta sesheta requested a review from KPostOffice July 23, 2021 08:19
@sesheta sesheta added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 23, 2021
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor issues

ubi8-py36/requirements.txt Outdated Show resolved Hide resolved
ubi8-py38/requirements.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@fridex fridex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, lgtm otherwise.

f32-py38/s2i_assemble.patch Outdated Show resolved Hide resolved
Signed-off-by: Francesco Murdaca <[email protected]>
@pacospace pacospace force-pushed the update-req.in branch 2 times, most recently from 3d9abc5 to 3279c79 Compare July 26, 2021 07:57
Copy link
Contributor

@fridex fridex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏻

@sesheta
Copy link
Member

sesheta commented Jul 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2021
@sesheta
Copy link
Member

sesheta commented Jul 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta merged commit 25ad8a4 into thoth-station:master Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants