Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with thoth config not generated from template #200

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Fix issue with thoth config not generated from template #200

merged 1 commit into from
Jul 23, 2021

Conversation

fridex
Copy link
Contributor

@fridex fridex commented Jul 23, 2021

This introduces a breaking change

  • No

@fridex fridex requested review from goern and sesheta as code owners July 23, 2021 12:34
@sesheta sesheta requested review from KPostOffice and pacospace July 23, 2021 12:34
@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 23, 2021
pacospace
pacospace approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@pacospace pacospace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! 💯

@fridex
Copy link
Contributor Author

fridex commented Jul 23, 2021

/approve

@sesheta
Copy link
Member

sesheta commented Jul 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex, pacospace

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2021
@sesheta sesheta merged commit 7dde9e0 into thoth-station:master Jul 23, 2021
@pacospace pacospace mentioned this pull request Jul 23, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacospace pacospace pacospace approved these changes

@goern goern Awaiting requested review from goern goern is a code owner

@sesheta sesheta Awaiting requested review from sesheta sesheta is a code owner

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fridex @sesheta @pacospace