Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker build optimization #213

Merged
merged 2 commits into from
Sep 23, 2021

Conversation

guimou
Copy link
Contributor

@guimou guimou commented Aug 5, 2021

This introduces a breaking change

  • Yes
  • [X ] No

This Pull Request implements

Add cleaning instructions after yum update in the Dockerfile(s) to gain size on images.
Gain is not that important, image size for ubi8-py38 is 1.1GB vs 1.11GB without it, but it's best practice in general.

Description

Simply added instructions after the yum update.
yum --assumeyes clean all &&
rm -rf /var/cache/yum

@guimou guimou requested review from fridex, goern and sesheta as code owners August 5, 2021 18:43
@sesheta sesheta added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 5, 2021
@sesheta
Copy link
Member

sesheta commented Aug 5, 2021

Hi @guimou. Thanks for your PR.

I'm waiting for a thoth-station member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harshad16
Copy link
Member

/ok-to-test
This is great, thanks 💯

@sesheta sesheta added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 5, 2021
@sesheta
Copy link
Member

sesheta commented Sep 4, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@sesheta
Copy link
Member

sesheta commented Sep 4, 2021

@sesheta: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta closed this Sep 4, 2021
@pacospace pacospace reopened this Sep 6, 2021
@goern
Copy link
Member

goern commented Sep 23, 2021

why havent we merged this?!

/approve

thanks @guimou

@sesheta
Copy link
Member

sesheta commented Sep 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: goern

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2021
@sesheta sesheta merged commit a832a08 into thoth-station:master Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants