Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installing python3.8 and bumping version of thamos to latest #239

Conversation

Gregory-Pereira
Copy link
Member

Related Issues and Dependencies

Addresses: thoth-station/support#204

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

Bumping version of thamos, installing python3.8 so thamos install does not fail, adding other transative dependency of rich_click

@sesheta
Copy link
Member

sesheta commented Mar 24, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fridex after the PR has been reviewed.
You can assign the PR to them by writing /assign @fridex in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 24, 2022
@sesheta
Copy link
Member

sesheta commented Mar 24, 2022

@Gregory-Pereira: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
aicoe-ci/prow/pre-commit dd9418a link true /test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Gregory-Pereira
Copy link
Member Author

Closing this issue, is already being addressed by #238 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants