Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

creating deployment overlay for solver-f35-py310 #5151

Merged
merged 1 commit into from
Mar 18, 2022
Merged

creating deployment overlay for solver-f35-py310 #5151

merged 1 commit into from
Mar 18, 2022
+1,252 −0

Conversation

Gregory-Pereira
Copy link
Member

Related Issues and Dependencies

Addresses: thoth-station/s2i-thoth#231
Related to: thoth-station/s2i-thoth#235

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

Create a new solver image from recently created base image https://quay.io/repository/thoth-station/s2i-thoth-f35-py310/.

@sesheta sesheta added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 15, 2022
@Gregory-Pereira Gregory-Pereira force-pushed the create-solver-f35-py310-overlay branch from 481d20e to 4584a2d Compare March 15, 2022 18:09
@Gregory-Pereira
Copy link
Member Author

/cc @fridex

@sesheta sesheta requested a review from fridex March 15, 2022 18:10
@Gregory-Pereira Gregory-Pereira mentioned this pull request Mar 15, 2022
Merged
1 task
fridex
fridex reviewed Mar 16, 2022
View reviewed changes
Copy link
Contributor

@fridex fridex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, otherwise lgtm 👍🏻 thanks!

overlays/solver-fedora-35-py310/Pipfile.lock
@@ -0,0 +1,1201 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this lock file generated inside quay.io/thoth-station/s2i-thoth-f35-py310:v0.32.3? I see the python version properly stated to 3.10, but just to make sure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified the pipfile lock in my system, seems to be the same and has the same sha.
we are good with this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks 👍🏻

fridex
fridex approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@fridex fridex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Gregory-Pereira 💯 👍🏻

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2022
@harshad16
Copy link
Member

/hold

@sesheta sesheta added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2022
harshad16
harshad16 requested changes Mar 17, 2022
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good to be merged
please include the solver in here too:

solver/.thoth.yaml

Line 6 in 1d8ba2a

runtime_environments:

@fridex
Copy link
Contributor

fridex commented Mar 17, 2022

I've also verified running solver testsuite in the quay.io/thoth-station/s2i-thoth-f35-py310:v0.32.3 base. It looks like solver works well for Fedora 35 running Python 3.10.

@fridex fridex force-pushed the create-solver-f35-py310-overlay branch from 4ecc7c6 to 4584a2d Compare March 17, 2022 10:06
@Gregory-Pereira Gregory-Pereira force-pushed the create-solver-f35-py310-overlay branch from 4584a2d to 0b9074e Compare March 17, 2022 17:07
@Gregory-Pereira
Copy link
Member Author

runtime_environment for f35-py310 has been added. Thanks for the feedback and testing Frido and Harshad!

harshad16
harshad16 approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thanks 💯

@harshad16
Copy link
Member

/unhold

@sesheta sesheta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2022
@sesheta
Copy link
Member

sesheta commented Mar 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex, harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta merged commit eb090f3 into thoth-station:master Mar 18, 2022
@harshad16 harshad16 mentioned this pull request Mar 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fridex fridex fridex approved these changes

@harshad16 harshad16 harshad16 approved these changes

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gregory-Pereira @harshad16 @fridex @sesheta