Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix software_environment_id null violation #2748

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

harshad16
Copy link
Member

Fix software_environment_id null violation
Signed-off-by: Harshad Reddy Nalla [email protected]

Related Issues and Dependencies

Related-to: #2745

This should yield a new module release

  • Yes
  • No

Description

Mentioned the details: #2745 (comment)

@goern goern requested a review from mayaCostantini January 13, 2023 09:23
@goern
Copy link
Member

goern commented Jan 13, 2023

/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2023
Copy link
Contributor

@mayaCostantini mayaCostantini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2023
@goern
Copy link
Member

goern commented Jan 16, 2023

/approve

@sesheta
Copy link
Member

sesheta commented Jan 16, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: goern, mayaCostantini
Once this PR has been reviewed and has the lgtm label, please ask for approval from harshad16 by writing /assign @harshad16 in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2023
@harshad16
Copy link
Member Author

Thanks all for the review
Merging for the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants