Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release of version 1.3.1 #599

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Release of version 1.3.1 #599

merged 1 commit into from
Nov 10, 2020

Conversation

sesheta
Copy link
Member

@sesheta sesheta commented Nov 10, 2020

Hey, @fridex!

Opening this PR to fix the last release.

Related: #598


Changelog:
### Features
* Remove sleep before first attempt to obtain results (#569)
* Adjust host to User API in the README (#597)
### Automatic Updates
* :pushpin: Automatic update of dependency rich from 9.1.0 to 9.2.0 (#595)
* :pushpin: Automatic update of dependency micropipenv from 1.0.0 to 1.0.1 (#594)
* :pushpin: Automatic update of dependency rich from 9.1.0 to 9.2.0 (#593)

@sesheta sesheta added the bot This Issue or PR is being worked on by a bot label Nov 10, 2020
Copy link

@sefkhet-abwy sefkhet-abwy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an auto-approve of an auto-PR.

@sefkhet-abwy sefkhet-abwy bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2020
@sesheta
Copy link
Member Author

sesheta commented Nov 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: sefkhet-abwy[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@sesheta
Copy link
Member Author

sesheta commented Nov 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: sefkhet-abwy[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 10, 2020
@sesheta sesheta merged commit f7b3478 into master Nov 10, 2020
@fridex fridex deleted the v1.3.1 branch November 10, 2020 17:00
@goern
Copy link
Member

goern commented Nov 11, 2020

@harshad16 wrt your demo on last sprint demo session, can this even 'issue clue' trigger a rebuild of the thoth-toolbox container image?

@harshad16
Copy link
Member

@goern i think we need something like a post trigger, as the current sync pipeline does synchronous release, which in this case would be a race.

  • if the thamos release finishes first, then it's good, as thamos new release will be available in pypi.
  • if thoth-toolbox release get the resources and finish first, then old thamos would be available in the image.

we would need a post-trigger, which triggers a release of thoth-toolbox when release of thamos is completed.
we can do that in the pipeline, will create an issue, and can get those changes in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bot This Issue or PR is being worked on by a bot size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants