make callback secret optional

if no requests have been made with callback secret combine, then no secret will exist, by making the secret optional the volume that is mounted will be empty and still allow the step to run Signed-off-by: Kevin <[email protected]>
thoth-station · Nov 30, 2022 · 46440cc · 46440cc
1 parent b65527d
commit 46440cc
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/adviser/base/openshift-templates/adviser.yaml b/adviser/base/openshift-templates/adviser.yaml
@@ -203,6 +203,7 @@ objects:
         - name: callback-secret
           secret:
             secretName: "callback-{{workflow.parameters.THOTH_DOCUMENT_ID}}"
+            optional: true
 
       templates:
         - name: "adviser"

diff --git a/core/base/send-webhooks-sa.yaml b/core/base/send-webhooks-sa.yaml
@@ -27,3 +27,15 @@ roleRef:
 subjects:
   - kind: ServiceAccount
     name: send-webhooks
+---
+apiVersion: rbac.authorization.k8s.io/v1
+kind: RoleBinding
+metadata:
+  name: send-webhooks-argo
+roleRef:
+  apiGroup: rbac.authorization.k8s.io
+  kind: ClusterRole
+  name: argo
+subjects:
+  - kind: ServiceAccount
+    name: send-webhooks