Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send webhook container halts if the callback secret is not present #2677

Closed
1 of 5 tasks
harshad16 opened this issue Oct 7, 2022 · 2 comments · Fixed by #2702
Closed
1 of 5 tasks

send webhook container halts if the callback secret is not present #2677

harshad16 opened this issue Oct 7, 2022 · 2 comments · Fixed by #2702
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/devsecops Categorizes an issue or PR as relevant to SIG DevSecOps. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@harshad16
Copy link
Member

harshad16 commented Oct 7, 2022

Describe the bug
The new callback feature component send-webhook container halts for callback secrets as it is volume mounted.
As the thamos sync based on user-api schema, the new thamos version would create default callback call on advise request.
However old version wouldn't provide callback call, which would cause this issue.

Screenshot from 2022-10-07 14-30-45

To Reproduce
Steps to reproduce the behavior:

  1. Execute a thamos advise from older version of thamos.
  2. Go to the cluster
  3. Scroll down to send-webhook container.
  4. See error

Expected behavior
Smooth transition of send-webhook.

Possible solutions

  • Make the secret mount optional on adviser workflow. ex: here
    or
  • Explore the option of having a condition on argo workflow to check if secrets exists, if not then don't mount.
    or
  • create a dumpy secret entry for the callback-url and handle it process in workflow-helper and user-api.

Acceptance criteria

  • Fix the adviser run from failing due to wait time on secret mount.
  • Verify the adviser run execute properly.
@harshad16 harshad16 added the kind/bug Categorizes issue or PR as related to a bug. label Oct 7, 2022
@harshad16 harshad16 moved this to 🆕 New in Planning Board Oct 7, 2022
@harshad16
Copy link
Member Author

/sig devsecops
/priority important-soon

@sesheta sesheta added sig/devsecops Categorizes an issue or PR as relevant to SIG DevSecOps. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Oct 7, 2022
@harshad16 harshad16 moved this from 🆕 New to 🔖 Next in Planning Board Nov 17, 2022
@harshad16
Copy link
Member Author

/triage accepted

@sesheta sesheta added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Nov 17, 2022
@harshad16 harshad16 assigned harshad16 and KPostOffice and unassigned harshad16 Nov 17, 2022
@KPostOffice KPostOffice moved this from 🔖 Next to 👀 In review in Planning Board Nov 22, 2022
Repository owner moved this from 👀 In review to ✅ Done in Planning Board Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/devsecops Categorizes an issue or PR as relevant to SIG DevSecOps. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants