make callback secret optional #2702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
sesheta
added
do-not-merge/hold
KPostOffice
force-pushed
the
callback-optional
branch
3 times, most recently
from
ca930cf to
1c04c1e
Compare
sesheta
added
size/S
KPostOffice
force-pushed
the
callback-optional
branch
7 times, most recently
from
46440cc to
23864b6
Compare
if no requests have been made with callback secret combine, then no secret will exist, by making the secret optional the volume that is mounted will be empty and still allow the step to run Signed-off-by: Kevin <[email protected]>
KPostOffice
force-pushed
the
callback-optional
branch
from
23864b6 to
0a28713
Compare
harshad16
reviewed
Dec 2, 2022
Signed-off-by: Kevin <[email protected]>
sesheta
added
size/L
harshad16
approved these changes
Dec 2, 2022
sesheta
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if no requests have been made with callback secret combine, then no secret will exist, by making the secret optional the volume that is mounted will be empty and still allow the step to run
Signed-off-by: Kevin [email protected]
Related Issues and Dependencies
fixes: #2677
Does this require new deployment ?
AICoE/aicoe-cdand Prodoperate-first/argocd-apps.