Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache expiration value #2631

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

mayaCostantini
Copy link
Contributor

Related Issues and Dependencies

It had been set to 12 hours in the configmap.
The default value when this environment variable is not present for user api is 3 hours, but we can leave it as 4 hours here if needed.

@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 23, 2022
@sesheta sesheta requested review from goern and harshad16 August 23, 2022 12:50
@sesheta
Copy link
Member

sesheta commented Aug 23, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from mayacostantini after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2022
@harshad16 harshad16 merged commit 11bce71 into thoth-station:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants