Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for setup.cfg #15

Open
mayaCostantini opened this issue Jun 23, 2022 · 5 comments
Open

Support for setup.cfg #15

mayaCostantini opened this issue Jun 23, 2022 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance.

Comments

@mayaCostantini
Copy link
Contributor

Problem statement

Similarly to the Thoth GitHub Action, we should support repositories with requirements stated in a setup.cfg file.

Alternatives

Only support pip and pipenv formats.
@mayaCostantini mayaCostantini added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 23, 2022
@mayaCostantini
Copy link
Contributor Author

/sig stack-guidance
/lifecycle active
/priority important-soon

@sesheta sesheta added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 23, 2022
@mayaCostantini mayaCostantini self-assigned this Jun 27, 2022
@TomasTomecek
Copy link
Contributor

Yup, this would super helpful to us!

TomasTomecek added a commit to TomasTomecek/ogr that referenced this issue Jun 30, 2022
@TomasTomecek
DO NOT MERGE: temporarily add req.txt
740c0b0 
before thoth-station/thoth-pre-commit-hook#15
is implemented

Signed-off-by: Tomas Tomecek <[email protected]>
@mayaCostantini
Copy link
Contributor Author

Perfect, I will start working on that soon 👍

TomasTomecek added a commit to TomasTomecek/ogr that referenced this issue Jun 30, 2022
@TomasTomecek
DO NOT MERGE: temporarily add req.txt
fd74301 
before thoth-station/thoth-pre-commit-hook#15
is implemented

Signed-off-by: Tomas Tomecek <[email protected]>
@mayaCostantini mayaCostantini mentioned this issue Jul 8, 2022
Closed
@codificat codificat moved this to 🏗 In progress in Planning Board Sep 24, 2022
@sesheta
Copy link
Member

sesheta commented Sep 28, 2022

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. labels Sep 28, 2022
@harshad16
Copy link
Member

/remove-lifecycle stale
/lifecycle frozen

@sesheta sesheta added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 4, 2022
@mayaCostantini mayaCostantini removed their assignment Dec 1, 2022
@mayaCostantini mayaCostantini moved this from 🏗 In progress to 📋 Backlog in Planning Board Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance.
Projects
Planning Board
Status: 📋 Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP Add support for setup.cfg mayaCostantini/thoth-pre-commit-hook
4 participants
@TomasTomecek @harshad16 @sesheta @mayaCostantini