create new python script for sending webhooks in a directory #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesheta
added
the
size/XL
KPostOffice
force-pushed
the
send-callbacks
branch
from
9f88ef1 to
7ca3918
Compare
KPostOffice
force-pushed
the
send-callbacks
branch
from
7ca3918 to
039c569
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
approved
KPostOffice
force-pushed
the
send-callbacks
branch
from
039c569 to
4e24efe
Compare
|
New changes are detected. LGTM label has been removed. |
harshad16
reviewed
Jun 23, 2022
send_webhooks.py
Outdated
Comment on lines
45
to
47
| _LOGGER.exception(e) | ||
|
|
||
| k8.client.CoreV1Api.delete_namespaced_secret(name=f"callback-{document_id}", namespace=secret_namespace) |
There was a problem hiding this comment.
secret would be deleted even if exception occures as we are not raising it.
is this intentional ?
There was a problem hiding this comment.
I don't think the onus is on us if webhook fails to deliver, the most common reasons it would fail in my opinion is if an invalid URL or authentication is provided. Let me know what you think.
harshad16
removed
the
approved
KPostOffice
force-pushed
the
send-callbacks
branch
from
4e24efe to
088e2bc
Compare
sesheta
added
the
approved
KPostOffice
force-pushed
the
send-callbacks
branch
from
088e2bc to
8837cc7
Compare
sesheta
added
size/L
KPostOffice
force-pushed
the
send-callbacks
branch
from
8837cc7 to
a9fca5d
Compare
created a simple python script which iterates over a directory and sends a post request to the specified url with the completed document id and any client data that came with the original request.
KPostOffice
force-pushed
the
send-callbacks
branch
from
a9fca5d to
965c892
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created a simple python script which iterates over a directory and
sends a post request to the specified url with the completed
document id and any client data that came with the original
request.
Related Issues and Dependencies
closes: #396
This introduces a breaking change