Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase migration:grade-icon onto origin/8.0.x #259

Open
wants to merge 3 commits into
base: 8.0.x
Choose a base branch
from

Conversation

Shounaks
Copy link

@Shounaks Shounaks commented Nov 13, 2024

Description

The purpose of grade-icon is to provide a unified simple component, for displaying the grade student is expecting.
Refer Documentation PR for Initial Information: thoth-tech/documentation#561
Refer Previous Declined PR (for dev branch.). This PR has been rebased to match with 8.0.x: #258

Fixes # (issue)

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I have tested this code is working in browser and will be appending screenshots for the following to the Documentation PR.

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [] I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from @macite and @jakerenzella on the Pull Request

Screenshots Before Change:

students-list

image

portfolios:

image
image

group-member-contribution-assigner:

image

Student Group

image

Screenshots After Change:

students-list

image

portfolios:

image
image

group-member-contribution-assigner:

image

Student Group

image

Other Images

image

@Shounaks Shounaks mentioned this pull request Nov 13, 2024
10 tasks
@satikaj
Copy link
Collaborator

satikaj commented Nov 18, 2024

Please add the before and after screenshots to this PR. Include screenshots of all places where the grade-icon is used.

Copy link
Collaborator

@satikaj satikaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some mentions of grade-icon were not addressed. Double check this. You can search up all occurrences of 'grade-icon' in VS Code

src/app/common/grade-icon/grade-icon.component.html Outdated Show resolved Hide resolved
src/app/common/grade-icon/grade-icon.component.scss Outdated Show resolved Hide resolved
src/app/common/grade-icon/grade-icon.component.ts Outdated Show resolved Hide resolved
src/app/common/grade-icon/grade-icon.component.ts Outdated Show resolved Hide resolved
src/app/common/grade-icon/grade-icon.component.ts Outdated Show resolved Hide resolved
@Shounaks
Copy link
Author

Shounaks commented Nov 18, 2024

Thanks @satikaj , for the tasks, will target to finish them by EOD.

  • use f-grade-icon
  • Parent components may not always pass in a number. They may pass in a string. In old angular.js file, they checked first if it was a string
  • (Survey of ) is this still needed?
  • add the Tailwind classes to the html in this PR
  • ng-class shouldn't be used anymore

Copy link
Collaborator

@satikaj satikaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include before screenshots as well

src/app/common/grade-icon/grade-icon.component.ts Outdated Show resolved Hide resolved
src/app/common/grade-icon/grade-icon.component.ts Outdated Show resolved Hide resolved
@satikaj
Copy link
Collaborator

satikaj commented Nov 23, 2024

Good job! Can you please make a PR to the upstream (doubtfire-lms version of doubtfire-web)?

@Shounaks
Copy link
Author

Thanks @satikaj , here is the upstream PR link: doubtfire-lms#898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants