Drop active_job from the dependencies. #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nickcharlton, I'm poking around here. This requires us to depend on Rails |
|
I'm not sure how to read the Rails' team's notation on rails/rails@d3dc651: |
|
👋 @thecalliopecrashed I think you're right. That tag symbol should mean that the commit will be included in that release. I do wonder if this has additional implications when Rails 6 is released. Will we need to conditionally add |
nickcharlton
force-pushed
the
nc-drop-active-job
branch
from
bcf004d to
eb8d4da
Compare
In #8bc80cf, we needed to add `active_job` to the dependencies to allow database seeding to continue to work. This was raised in rails/rails#35782 and fixed in rails/rails@d3dc651
nickcharlton
force-pushed
the
nc-drop-active-job
branch
from
eb8d4da to
65176b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 8bc80cf, we needed to add
active_jobto the dependencies to allow database seeding to continue to work.This was raised in rails/rails#35782 and fixed in rails/rails@d3dc651