Add CSP tags to default layout #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betelgeuse
force-pushed
the
include_csp_tag
branch
from
43a66e9 to
060ad3e
Compare
| @@ -23,6 +23,8 @@ By default, it renders: | |||
| </title> | |||
| <%= render "stylesheet" %> | |||
| <%= csrf_meta_tags %> | |||
| <%# Added in Rails 5.2 %> | |||
There was a problem hiding this comment.
Can we drop the comment? I don't think we need it as it'll be there now for a long time
There was a problem hiding this comment.
I was thinking it would increase the chances that the defined? would be dropped when only >= 5.2 is supported. Should we inspect Rails::VERSION?
There was a problem hiding this comment.
Ah yes. I think we're okay here: we should mention in the commit message that exists from Rails 5.2 and up.
There was a problem hiding this comment.
I created an issue to look into compatibility detection: #1631
nickcharlton
added
views-and-styles
This is needed to get Trix and CSP to play together.
nickcharlton
force-pushed
the
include_csp_tag
branch
from
060ad3e to
6a74fbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to get Trix and CSP to play together.