-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ew move readme to special files #1705
Ew move readme to special files #1705
Conversation
Co-Authored by: Kehinde Olofinmoyin <[email protected]>
…- requires refactoring
Co-Authored by: Kehinde P. Olofinmoyin <[email protected]>
Co-authored by: Kehinde Olofinmoyin <[email protected]>
@EWright212, this appears to be the same as #1698, but with two additional commits. Is this an accident? |
Hi @pablobm! No, this is a new branch to solve a different issue (being that the README has a table in it that doesn't look nice on GitHub). However it is based on the logic from the previous commit which broke symlinks, as discussed with @nickcharlton. |
Oh, I see. The problem here is that the PR becomes difficult to review, because it comes with a number of unrelated changes. This happens sometimes, and it can be a bit tricky. Here are a couple of options:
Option 2 is probably what I would do here, but it may still involve rebasing things later when the first PR is merged, and changing this back to |
I don't think we can do that as it's from a fork 👀 Let's get the original merged and then come back to this, as that'll make life a bit easier. |
As we've merged #1698, do you think we could rebase this? |
I don't seem to be able to force push this branch now I've rebased it, so I just opened #1776. |
No description provided.