Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove inline style from icon svg #2115

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Remove inline style from icon svg #2115

merged 1 commit into from
Jan 24, 2022

Conversation

michaelbaisch
Copy link
Contributor

Fixes #2087

pablobm
pablobm reviewed Jan 20, 2022
View reviewed changes
Copy link
Collaborator

@pablobm pablobm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this :-) Just one question!

app/views/administrate/application/_icons.html.erb Show resolved Hide resolved
@nickcharlton nickcharlton merged commit 94074f3 into thoughtbot:main Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablobm pablobm pablobm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inline Style doesn't work with Content Security Policy
3 participants
@michaelbaisch @pablobm @nickcharlton