Change ApplicationController's routes's class to Set to speed up "valid_action?" #2182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed ApplicationController's routes's class to Set to speed up
valid_action?
.Let
N
be number of routes.valid_action?
checks all routes in current version. So the time complexity isO(N)
.When we store
routes
as Set, the time complexity isO(log N)
.My application has hundreds of routes.
valid_action?
took a long time.