Correctly detect filters with non-word params #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the filter regex to return valid filter matches when the filter attribute isn't an ascii word object.
|
can you explain more? I do not see related between this and #2252 |
pablobm
reviewed
Oct 6, 2022
Only check the part of the section before `:` for valid filters Co-authored-by: Pablo Brasero <[email protected]>
|
Looks good. Thank you! |
|
it's should fixed for #2265 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the filter regex to return valid filter matches when the filter attribute isn't an ascii word object.
This fixes #2228 as well as allowing using comma separated values when filtering
It shouldn't matter when checking for the existence of a
filterwhether the characters to the right of the:in thewordobject contain things like unicode characters or punctuation.