make permitted_attributes support action #2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jubilee2
force-pushed
the
permitted_attributes-update
branch
from
a4a3b41 to
ea76c97
Compare
jubilee2
force-pushed
the
permitted_attributes-update
branch
from
5b04caf to
36fb3ab
Compare
jubilee2
force-pushed
the
permitted_attributes-update
branch
from
a913637 to
0034879
Compare
pablobm
reviewed
Apr 18, 2023
pablobm
reviewed
Apr 19, 2023
Comment on lines
69
to
73
|
|
||
| it "assigns the action name as a string" do | ||
| get :index | ||
| expect(controller.action_name).to be_a(String) | ||
| end |
There was a problem hiding this comment.
Can you also remove this, please? This is standard Rails behaviour and unrelated to this feature, so it doesn't need to be tested. Sorry I missed this yesterday.
There was a problem hiding this comment.
I want make sure action name is string not symbo, anyway I can remove it
action =
case action
when "update" then "edit"
when "create" then "new"
else action
end
pablobm
approved these changes
Apr 19, 2023
|
Thank you again! |
littleforest
added a commit
to ApprenticeshipStandardsDotOrg/ApprenticeshipStandardsDotOrg
that referenced
this pull request
Nov 30, 2023
* Add GenericRecord field type There was no way to display the StandardsImport associated with a SourceFile, since there wasn't a built-in association between the objects. This adds a new GenericRecord administrate field that display a link to the record. * Fixed editing of StandardsImport The StandardsImport uses custom permitted_params but the latest Administrate release had updated that method to take a parameter thoughtbot/administrate#2356
littleforest
added a commit
to ApprenticeshipStandardsDotOrg/ApprenticeshipStandardsDotOrg
that referenced
this pull request
Nov 30, 2023
* Add GenericRecord field type There was no way to display the StandardsImport associated with a SourceFile, since there wasn't a built-in association between the objects. This adds a new GenericRecord administrate field that display a link to the record. * Fixed editing of StandardsImport The StandardsImport uses custom permitted_params but the latest Administrate release had updated that method to take a parameter thoughtbot/administrate#2356
littleforest
added a commit
to ApprenticeshipStandardsDotOrg/ApprenticeshipStandardsDotOrg
that referenced
this pull request
Nov 30, 2023
* Add GenericRecord field type There was no way to display the StandardsImport associated with a SourceFile, since there wasn't a built-in association between the objects. This adds a new GenericRecord administrate field that display a link to the record. * Fixed editing of StandardsImport The StandardsImport uses custom permitted_params but the latest Administrate release had updated that method to take a parameter thoughtbot/administrate#2356
littleforest
added a commit
to ApprenticeshipStandardsDotOrg/ApprenticeshipStandardsDotOrg
that referenced
this pull request
Nov 30, 2023
* Add GenericRecord field type There was no way to display the StandardsImport associated with a SourceFile, since there wasn't a built-in association between the objects. This adds a new GenericRecord administrate field that display a link to the record. * Fixed editing of StandardsImport The StandardsImport uses custom permitted_params but the latest Administrate release had updated that method to take a parameter thoughtbot/administrate#2356
littleforest
added a commit
to ApprenticeshipStandardsDotOrg/ApprenticeshipStandardsDotOrg
that referenced
this pull request
Dec 1, 2023
* Add GenericRecord field type There was no way to display the StandardsImport associated with a SourceFile, since there wasn't a built-in association between the objects. This adds a new GenericRecord administrate field that display a link to the record. * Fixed editing of StandardsImport The StandardsImport uses custom permitted_params but the latest Administrate release had updated that method to take a parameter thoughtbot/administrate#2356
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2352 and #2066