Fix Rails 6.0 load_server incompatibility
#2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Back when we upgraded Rails, we added this as it's now standard. But we still support 6.0 which doesn't have this. This was noticed when running `bundle exec appraisal rails60 rails rspec` locally where the tests all fail for this version of Rails. Running `rails s` hinted that this might be the problem and not calling it means the tests now run. #1841
pablobm
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back when we upgraded Rails, we added this as it's now standard. But we still support 6.0 which doesn't have this.
This was noticed when running
bundle exec appraisal rails60 rails rspeclocally where the tests all fail for this version of Rails. Runningrails shinted that this might be the problem and not calling it means the tests now run.#1841