Add Administrate::Punditize methods as module methods

[jordan-brough]

Instead of adding them via included do.

---

Note: It's easiest to view this diff if you hide whitespace changes:

---

If these methods are added via included do it makes it hard to override the method in an app's controller.

Example:

module Admin
  class ApplicationController < Administrate::ApplicationController
    include Administrate::Punditize

    def scoped_resource
      super.where(archived: false)
    end
  end
end

That example will skip pundit completely, because the def scoped_resource from Administrate::Punditize was added via included do, which means it will behave as if we had defined the method inline twice in Admin ::ApplicationController, which will result in the first definition from Administrate::Punditize being ignored. And the super in the code snippet above will refer to the non-punditized definition provided in the base class Administrate::ApplicationController:

administrate/app/controllers/administrate/application_controller.rb

Lines 192 to 194 in cda8da9

	def scoped_resource
	resource_class.default_scoped
	end

This seems unexpected to me, and makes it hard to add functionality that layers on top of what Administrate::Punditize does.

However, if we define def scoped_resource as a module method in Administrate::Punditize then super in Admin::ApplicationController will refer to the method defined in Administrate::Punditize.

Are there gotchas that I'm missing? Is there a reason that some of the methods
in Administrate::Punditize were defined via included do and others were
added as module methods?

[pablobm]

Thank you for this PR @jordan-brough. What you say makes sense to me. I don't know why this was implemented as a concern in the first place. In fact, would we need extend ActiveSupport::Concern any more?

Let me ping @nickcharlton to triple check that we are not missing anything here.

[pablobm]

This has waited long enough. Merging. If it breaks something... we'll be let know!