-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RichText field type #2411
Add RichText field type #2411
Conversation
Will look into the failing tests, some of them are not failing for me locally :( |
I had a look. It appears to be order-dependent. Specifically, when I run en example from administrate/spec/support/generator_spec_helpers.rb Lines 38 to 41 in 852b62c
So it looks that, whatever happens there, it deletes the Thoughts? |
Are we planning to release this anytime soon - Need this badly for actiontext |
@littleforest, are you able to pick up from @seanpdoyle's comments here? (If not, I can do so!) |
@nickcharlton I will see if I can find time to work on this second week of January. Might go faster if I can find time to pair with you or @seanpdoyle . |
8840fa1
to
d9a30f3
Compare
@littleforest, sorry, only getting back to this one now. How did you get on? Feel free to drop some time on my calendar if you've like to pair on this. |
@littleforest the asset changes merged as part of #2397 have introduced merge conflicts. If you're interested, I'm willing to give resolving those conflicts a try and force-pushing to this branch. If not, and you'd rather handle that yourself, that's great too! |
That would be amazing! Thank you. |
@seanpdoyle @nickcharlton @pablobm this is ready for re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Just one thought on added dependencies, but we should be able to merge this shortly.
f7ce9fb
to
18f3e67
Compare
I've just rebased, and I'll let the tests run before merging this in. For those following along, it'll go out with our next v1.0 beta release, which I hope to do soon, but I'm behind things at the moment so it might be a while. |
This adds a field for RichText, based on ActionText. It builds on work started in #1680.
18f3e67
to
0000254
Compare
Bundle audit is failing because of a security vulnerability in |
And merged. Thanks @sedubois for the original work, and @littleforest for consistently pushing this through! |
Hi @nickcharlton . Thanks for the work in this gem. Is the above still the case? As I don't see anywhere in the v1.0 releasementioning the addition of the RichText field type |
It's waiting on a second beta release, where it'll be included then. I'm going to try and do this today, so keep an eye out on the releases. |
This adds a RichText field type, completing the work started in #1660.