Avoid open-ended dependencies #2462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the current dependency specification, we get the following warnings
when building the gem:
```
WARNING: open-ended dependency on actionpack (>= 5.0) is not recommended
if actionpack is semantically versioned, use:
add_runtime_dependency 'actionpack', '~> 5.0'
WARNING: open-ended dependency on actionview (>= 5.0) is not recommended
if actionview is semantically versioned, use:
add_runtime_dependency 'actionview', '~> 5.0'
WARNING: open-ended dependency on activerecord (>= 5.0) is not recommended
if activerecord is semantically versioned, use:
add_runtime_dependency 'activerecord', '~> 5.0'
WARNING: open-ended dependency on kaminari (>= 1.0) is not recommended
if kaminari is semantically versioned, use:
add_runtime_dependency 'kaminari', '~> 1.0'
WARNING: See https://guides.rubygems.org/specification-reference/ for help
```
I think this makes sense. We don't know which changes Rails 8 or
Kaminari 2 may bring.
nickcharlton
approved these changes
Dec 12, 2023
nickcharlton
added a commit
that referenced
this pull request
Dec 12, 2023
In #2462, we forgot to include changes to `Gemfile.lock` and Circle didn't help us.
Merged
nickcharlton
added a commit
that referenced
this pull request
Dec 12, 2023
In #2462, we forgot to include changes to `Gemfile.lock` and Circle didn't help us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current dependency specification, we get the following warnings when building the gem:
I think this makes sense. We don't know which changes Rails 8 or Kaminari 2 may bring.