Remove CircleCI #2473
Merged
Remove CircleCI #2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablobm
approved these changes
Dec 28, 2023
sarahraqueld
approved these changes
Dec 28, 2023
In #1932, we migrated to GitHub Actions which is generally faster and has a simpler configuration. This completes that work by removing Circle CI. This commit will fail checks for Circle CI, which after it's merged we can disable in the UI.
nickcharlton
force-pushed
the
nc-remove-circleci
branch
from
23edf53 to
e9963c6
Compare
|
I'm confident that this is now working after opening a bunch of PRs. I've disabled CircleCI on the project so it doesn't get used for new PRs, but I'm pretty sure this will break existing PRs (which can't have GitHub Actions without recreating) which is annoying. But so is waiting for CircleCI to finish so that's the way has to be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1932, we migrated to GitHub Actions which is generally faster and has a simpler configuration. This completes that work by removing Circle CI.
This commit will fail checks for Circle CI, which after it's merged we can disable in the UI.